sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Fix: Custom resources do not implement to_json correctly #475

Closed Wing924 closed 6 years ago

Wing924 commented 7 years ago

Fix: #474

codecov-io commented 7 years ago

Codecov Report

Merging #475 into master will decrease coverage by 4.35%. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   71.51%   67.15%   -4.36%     
==========================================
  Files           7        7              
  Lines         337      338       +1     
==========================================
- Hits          241      227      -14     
- Misses         96      111      +15
Impacted Files Coverage Δ
libraries/consul_definition.rb 91.66% <100%> (+47.22%) :arrow_up:
libraries/consul_config.rb 79.71% <33.33%> (-18.11%) :arrow_down:
libraries/consul_watch.rb 48.48% <50%> (ø) :arrow_up:
libraries/consul_execute.rb 55% <0%> (-45%) :arrow_down:
libraries/helpers.rb 65.21% <0%> (+8.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b61636...c07ca3a. Read the comment docs.

Wing924 commented 7 years ago

@johnbellone The test was failed but not from my codes. Please check it.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.