sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Rename "to_json" to avoid collisions with built-in methods #476

Closed legal90 closed 6 years ago

legal90 commented 7 years ago

Fixes #474 Closes #475

We need to rename the method to_json in order to avoid collisions with Chef built-in methods having the same name.

cc @gdavison, @Wing924

codecov-io commented 6 years ago

Codecov Report

Merging #476 into master will decrease coverage by 5.04%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   71.51%   66.46%   -5.05%     
==========================================
  Files           7        7              
  Lines         337      337              
==========================================
- Hits          241      224      -17     
- Misses         96      113      +17
Impacted Files Coverage Δ
libraries/consul_watch.rb 90.9% <100%> (+42.42%) :arrow_up:
libraries/consul_definition.rb 44.44% <50%> (ø) :arrow_up:
libraries/consul_config.rb 80.29% <50%> (-17.52%) :arrow_down:
libraries/consul_execute.rb 55% <0%> (-45%) :arrow_down:
libraries/helpers.rb 65.21% <0%> (+8.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b61636...f34fbe5. Read the comment docs.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.