stop signal should be SIGINT not SIGTERM

sous-chefs / consul

Development repository for the consul cookbook

https://supermarket.chef.io/cookbooks/consul

Apache License 2.0

192 stars 244 forks source link

stop signal should be SIGINT not SIGTERM #479

Closed Wing924 closed 3 years ago

Wing924 commented 6 years ago

/etc/systemd/system/consul.service It should be:

--- /etc/systemd/system/consul.service  2017-11-17 07:22:20.041052788 +0000
+++ consul.service  2017-11-19 23:12:24.208171097 +0000
@@ -7,7 +7,7 @@
 Environment="GOMAXPROCS=2" "PATH=/usr/local/bin:/usr/bin:/bin"
 ExecStart=/opt/consul/1.0.0/consul agent -config-file=/etc/consul/consul.json -config-dir=/etc/consul/conf.d
 ExecReload=/bin/kill -HUP $MAINPID
-KillSignal=TERM
+KillSignal=INT
 User=consul
 WorkingDirectory=/var/lib/consul

TERM means force stop process while INT means graceful stop.

ref. https://www.consul.io/docs/agent/basics.html#stopping-an-agent

damacus commented 5 years ago

Hi there!

Thanks for taking the time to submit an issue.

We would happily accept a pull request to resolve this issue. If you need help or guidance on submitting, please don't hesitate to ask!

If you need help, or just wish to talk through issue please join the Chef Community Slack and look for the #sous-chefs channel.

Thanks, Sous-Chefs

theanirudhvyas commented 4 years ago

I'd like to pick up the issue, if it is still relevant. @damacus will raise a PR for it.

github-actions[bot] commented 3 years ago

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

github-actions[bot] commented 3 years ago

Closing due to inactivity. If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.