search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Proposal for Consul v1 parameter names #480

Closed gdavison closed 5 years ago

gdavison commented 6 years ago

With the release of Consul v1, a number of parameter names have been deprecated. See https://github.com/hashicorp/consul/blob/master/CHANGELOG.md, 1.0.0, Breaking Changes, "Deprecated Options Have Been Removed".

Most of the parameters have simplified equivalents in v1, so they can be mapped from v0.x to v1, but not from v1 to v0.x.

I propose adding the new parameters in addition to the deprecated parameters. If a user is installing v0.x and uses a new parameter, the run fails. If they are installing v1 and uses an old parameter, we map to the new parameter and write a warning in the log.

Any comments?

johnbellone commented 6 years ago

@gdavison This makes sense to me. In the long run, e.g. new major version, we'd want to remove the old parameters. But I would not suggest doing that for quite awhile.

damacus commented 5 years ago

Closing due to inactivity.

If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!

Thanks, Sous-Chefs

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.