sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Fix git install integration tests #488

Closed gdavison closed 6 years ago

gdavison commented 6 years ago

Updates to allow git-based installations.

codecov-io commented 6 years ago

Codecov Report

Merging #488 into master will decrease coverage by 0.66%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   60.81%   60.15%   -0.67%     
==========================================
  Files           8        8              
  Lines         393      399       +6     
==========================================
+ Hits          239      240       +1     
- Misses        154      159       +5
Impacted Files Coverage Δ
libraries/consul_service_windows.rb 35.89% <0%> (-12.83%) :arrow_down:
libraries/consul_config.rb 81.11% <0%> (+0.82%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 102cedc...7b0b55d. Read the comment docs.

johnbellone commented 6 years ago

I assume this isn't ready yet ;)

gdavison commented 6 years ago

Yeah, kitchen 1.20.0 seems to have an issue with a missing dependency. I got the same error at home until I updated.

gdavison commented 6 years ago

I think the Codecov error is spurious, @johnbellone @legal90

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.