sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Fix name collisions in helpers.rb #499

Closed knightorc closed 6 years ago

knightorc commented 6 years ago

When a run_list includes consul and hashicorp-vault their helpers inject into the node colliding def blocks.

Depending on the order of inclusion, consul or vault is used, when it should be the other.

Solves: https://github.com/johnbellone/consul-cookbook/issues/498

codecov-io commented 6 years ago

Codecov Report

Merging #499 into master will increase coverage by 15.28%. The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #499       +/-   ##
===========================================
+ Coverage    61.4%   76.69%   +15.28%     
===========================================
  Files           8        8               
  Lines         399      399               
===========================================
+ Hits          245      306       +61     
+ Misses        154       93       -61
Impacted Files Coverage Δ
libraries/consul_service_windows.rb 35.89% <0%> (-12.83%) :arrow_down:
libraries/helpers.rb 65.21% <100%> (+8.69%) :arrow_up:
libraries/consul_config.rb 97.9% <0%> (+16.78%) :arrow_up:
libraries/consul_watch.rb 90.9% <0%> (+42.42%) :arrow_up:
libraries/consul_execute.rb 100% <0%> (+45%) :arrow_up:
libraries/consul_definition.rb 91.66% <0%> (+47.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd0d583...7dfd4f0. Read the comment docs.

knightorc commented 6 years ago

Clossing - Reconsidering my fix.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.