search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Stop sending helper into node #500

Closed knightorc closed 6 years ago

knightorc commented 6 years ago

Removed: Chef::Node.send(:include, ConsulCookbook::Helpers) from helper Added extend ConsulCookbook::Helpers to attributes/default.rb

Run in windows, centos6 and centos7 via test kitchen.

Second kick at the can, so to speak. Solves: https://github.com/johnbellone/consul-cookbook/issues/498

codecov-io commented 6 years ago

Codecov Report

Merging #500 into master will increase coverage by 0.9%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #500     +/-   ##
=========================================
+ Coverage    61.4%   62.31%   +0.9%     
=========================================
  Files           8        8             
  Lines         399      398      -1     
=========================================
+ Hits          245      248      +3     
+ Misses        154      150      -4
Impacted Files Coverage Δ
libraries/helpers.rb 54.54% <ø> (-1.98%) :arrow_down:
libraries/consul_service_windows.rb 35.89% <0%> (-12.83%) :arrow_down:
libraries/consul_execute.rb 100% <0%> (+45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd0d583...f6ea29e. Read the comment docs.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.