sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

WIP: Enable CircleCI #508

Closed xorima closed 6 years ago

xorima commented 6 years ago

This PR will enable Circle CI Integration testing

xorima commented 6 years ago

Seems to be an issue with the orb not running bundle install @damacus Do you have any issue with a pr on orbs to add this command into the "lint" step?

damacus commented 6 years ago

psst, you need a Dangerfile

damacus commented 6 years ago

And the bundler error is because the Gemfile is full of Gems that are now in the chef-dk/chef-workstation.

You'll want to remove all of those tools.

xorima commented 6 years ago

Can I get some advice on the failing tests due to a bundle install not being run, how is the best way to approach this issue? (I haven't used gems before)

gdavison commented 6 years ago

You might have some trouble with this one, it’s a Poise-based cookbook, so it probably needs lots of those gems

On Oct 18, 2018, at 14:43, Xorima notifications@github.com wrote:

Can I get some advice on the failing tests due to a bundle install not being run, how is the best way to approach this issue? (I haven't used gems before)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

xorima commented 6 years ago

If we had a bundle install before the chef exec delivery do you think this would work?

damacus commented 6 years ago

I think we actually just need to look at removing poise once you've finished with most to the other problems

xorima commented 6 years ago

If you want to merge this @damacus feel free to, for now I will focus on the simpler circleci cookbooks and we can revisit this one at a later date

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.