search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Run latest cookstyle #537

Closed marcosvm closed 5 years ago

marcosvm commented 5 years ago

Description

Run latest cookstyle.

Issues Resolved

https://github.com/sous-chefs/consul/issues/535

→ cookstyle -a
Inspecting 42 files
...C......................................

Offenses:

metadata.rb:6:1: R: [Corrected] ChefDeprecations/LongDescriptionMetadata: The long_description metadata.rb method is not used and is unnecessary in cookbooks
long_description 'Application cookbook which installs and configures Consul.'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
metadata.rb:9:1: R: [Corrected] ChefDeprecations/RecipeMetadata: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the README.md file instead.
recipe 'consul::default', 'Installs and configures the Consul service.'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
metadata.rb:9:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
metadata.rb:10:1: R: [Corrected] ChefDeprecations/RecipeMetadata: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the README.md file instead.
recipe 'consul::client_gem', 'Installs the Consul Ruby client as a gem.'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
metadata.rb:10:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
metadata.rb:11:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
metadata.rb:16:2: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 1 instead of 0).
 # build-essential is obsolete in chef 14+
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
metadata.rb:19:1: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 1).
# build-essential is obsolete in chef 14+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
metadata.rb:20:1: R: [Corrected] ChefModernize/UnnecessaryDependsChef14: Don't depend on cookbooks made obsolete by Chef 14
depends 'build-essential' # ~FC121
^^^^^^^^^^^^^^^^^^^^^^^^^
metadata.rb:20:2: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 1 instead of 0).
 # ~FC121
 ^^^^^^^^
metadata.rb:28:1: R: [Corrected] ChefModernize/RespondToInMetadata: It is no longer necessary to use respond_to? in metadata.rb in Chef Infra Client 12.15 and later
source_url 'https://github.com/johnbellone/consul-cookbook' if respond_to?(:source_url)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
metadata.rb:29:1: R: [Corrected] ChefModernize/RespondToInMetadata: It is no longer necessary to use respond_to? in metadata.rb in Chef Infra Client 12.15 and later
issues_url 'https://github.com/johnbellone/consul-cookbook/issues' if respond_to?(:issues_url)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
metadata.rb:31:1: R: [Corrected] ChefModernize/RespondToInMetadata: It is no longer necessary to use respond_to? in metadata.rb in Chef Infra Client 12.15 and later
chef_version '>= 12.1' if respond_to?(:chef_version)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

42 files inspected, 13 offenses detected, 13 offenses corrected

Check List