search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

fix undefined method 'join_path' for PoiseArchive::Resources::PoiseAr… #546

Closed scalp42 closed 4 years ago

scalp42 commented 4 years ago

Fix for #545 (extend self keeps the instance methods public, but module_function makes them private.)

cc @tas50

scalp42 commented 4 years ago

See also https://github.com/rubocop-hq/ruby-style-guide/issues/556, I'm assuming cookstyle inherits from rubocop.

tas50 commented 4 years ago

This actually came up internally. We definitely need to disable this one. Rubocop treats them the same and they are not.

tas50 commented 4 years ago

Here's the Cookstyle PR to fix this: https://github.com/chef/cookstyle/pull/517