search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Update deps and chef #553

Closed SuperQ closed 4 years ago

SuperQ commented 4 years ago

Description

Update Chef minimum version.

Issues Resolved

Fixes: https://github.com/sous-chefs/consul/issues/503

Check List

xorima commented 4 years ago

@SuperQ

Thanks for this, as you have changed some of the platforms in the kitchen file, could you also update the platforms we test, they are in the .github/workflows/ci.yaml file under os:

Thanks!

SuperQ commented 4 years ago

@Xorima Oh, great, I didn't know about that. Done.

SuperQ commented 4 years ago

I'm not sure what's up with the spec helper error.

xorima commented 4 years ago

The failures are due to poise, which is an old unsupported way of writing cookbooks.

The whole cookbook needs a rewrite, but first off a member of sous chefs needs to understand consul in order to rewrite it.

SuperQ commented 4 years ago

Yea, I know, I'm currently trying to get our consul setup moved from PoC to production quality.

I already filed an issue about poise. I can't promise it, but I will see if I can find the time to remove the poise stuff.

xorima commented 4 years ago

@damacus have you looked into this one before for removing poise and it's complexity

@SuperQ what would be super useful would be if you can file some user stories around what you want to be able to do with this cookbook, it will make the refactor a lot easier if we know what people actually use it for

xorima commented 4 years ago

Released as well :D

SuperQ commented 4 years ago

The current functionality seems to be just fine for our use case.