search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Rewrite Consul cookbook to use custom resources #555

Closed emachnic closed 2 years ago

emachnic commented 4 years ago

:speaking_head: Foreword

Thank for taking the time to fill this feature request fully. Without it we may not be able to , and the issue may be closed without resolution.

:person_frowning: Problem Statement

This cookbook is a mess of custom libraries that are difficult to maintain.

:grey_question: Possible Solution

We should rewrite the Consul cookbook to use Chef custom resources

:arrow_heading_up: Describe alternatives you've considered

:heavy_plus_sign: Additional context

551

515

johnbellone commented 4 years ago

I totally agree here, but unfortunately do not have time to do it myself.

johnbellone commented 4 years ago

I think its fair to assume major version breaking changes. 🏛️🚚

emachnic commented 4 years ago

@johnbellone I've actually been working on a rewrite for this for a major version release that will leverage custom resources. It's been a long process thus far and I've had to refocus but hopefully be able to pick it back up

theanirudhvyas commented 4 years ago

Instead of doing a complete rewrite in a single commit, I'll suggest that we gradually migrate individual features (like consulDefinition) one at a time in separate releases. This will help us ensure backward compatibility and also reduce the probability of bugs. WDYT @johnbellone @emachnic ?

emachnic commented 4 years ago

@theanirudhvyas that would normally be the best way but, after having gone through a lot of this cookbook, a complete rewrite is probably the most expeditious.