Closed Sapr0 closed 3 years ago
This is really an upstream issue. I'm happy to see that you've opened up an issue and PR to get it fixed there.
This does bring up the fact that we don't test this at all in the current kitchen tests. Do you think you could add a suite which tests it so we can verify this is fixed upstream when it's released?
A new release of diplomat 2.5.0 has been created (which breaks the pre ruby 2.5 compatibility), hope it will fix the issue thanks to @Sapr0
@ramereth i looked at one of the runs: https://github.com/sous-chefs/consul/runs/1590571470?check_suite_focus=true
It seems the kitchen tests are on chef 17.0.1 Not sure how you want to test a combination of OS and chef version, it can easily explode into a cartesian product
I've re-run the cookbook and it now downloads the newest diplomat gem and everything is working as expected.
:speaking_head: Foreword
Thank for taking the time to fill this bug report fully. Without it we may not be able to fix the bug, and the issue may be closed without resolution.
:ghost: Brief Description
Cookbooks fails to load
diplomat
gem:pancakes: Cookbook version
4.3.1
:woman_cook: Chef-Infra Version
Chef Infra Client: 16.9.29
:tophat: Platform details
Amazon Linux AMI release 2018.03
Steps To Reproduce
Steps to reproduce the behavior:
:police_car: Expected behavior
I expect the cookbook to run without errors
:heavy_plus_sign: Additional context
According to Chef release notes https://docs.chef.io/release_notes_client/#whats-new-in-16929 most notable change was
Going down the rabbit hole, and comparing embedded gem list between 16.9.20 and 16.9.29 the
faraday
gem was bumped to1.3.0
among others.However, according to diplomat gemspec: https://github.com/WeAreFarmGeek/diplomat/blob/master/diplomat.gemspec#L28 They require
faraday
lower then 1.1.0, to support older versions of ruby.So while this seems like a diplomat gem issue, it's really a cookbook issue that decided to use this gem. According to chef stacktrace:
If we try to forcefully remove faraday 1.3.0:
Then we break chef entirely:
So now you need to put in your
metadata.rb
that you don't support Chef higher then16.9.29
, until you convince thediplomat
gem to fix the faraday requirement or chose a different implementation thendiplomat
gem