search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

When diplomat is not installed, failed with correct message #583

Closed pierresouchay closed 3 years ago

pierresouchay commented 3 years ago

This will ease investigations such as https://github.com/sous-chefs/consul/issues/582

Description

Will have a clear error message if diplomat fails to install such as a transitive dependency error.

Such message will be:

The diplomat gem is required; include recipe[consul::client_gem] to install, details: Unable to activate diplomat-2.5.0, because faraday-1.0.1 conflicts with faraday (~> 1.3)

instead of misleading:

The diplomat gem is required; include recipe[consul::client_gem] to install.

Issues Resolved

https://github.com/sous-chefs/consul/issues/582

kitchen-porter commented 3 years ago
1 Warning
:warning: This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

ramereth commented 3 years ago

@pierresouchay can you please include a changelog entry?

pierresouchay commented 3 years ago

@ramereth Done

kitchen-porter commented 3 years ago

Released as: 4.3.2