sous-chefs / consul

Development repository for the consul cookbook

https://supermarket.chef.io/cookbooks/consul

Apache License 2.0

192 stars 244 forks source link

fix up_to_date? methods for acl tokens and policies #604

Closed evandam closed 2 years ago

evandam commented 2 years ago

Description

The consul_token and consul_policy resources are not idempotent since the logic for comparing new/old values isn't valid (maybe it was for an older version of Consul/Diplomat at the time it was written). I tested on Consul 1.10.4 (Diplomat gem 2.5.1).

Check List

[x] A summary of changes made is included in the CHANGELOG under ## Unreleased
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

ramereth commented 2 years ago

@evandam can you please resolve the conflicts?

evandam commented 2 years ago

Hey @ramereth, rebased and all good 👌

ramereth commented 2 years ago

@evandam heh I just did a release and you need to fix it again. Sorry :(

evandam commented 2 years ago

:joy: all good, just rebased again @ramereth

kitchen-porter commented 2 years ago

Released as: 5.3.1