sous-chefs / cron

Development repository for the cron cookbook
https://supermarket.chef.io/cookbooks/cron
Apache License 2.0
78 stars 100 forks source link

Library cookbook refactor/Chef 17 compatibility #129

Closed bmhughes closed 3 years ago

bmhughes commented 3 years ago

Description

Issues Resolved

Check List

bmhughes commented 3 years ago

The minimum chef_version should be >= 15.0 since we're using unified_mode in all the resources.

Also, will any of these resources that are already builtins actually work on Chef 17?

Yes I've tested them with 17 (and CI runs with 17) and they work as expected, that was the sole driver for this PR.

I think this cookbook might need to be the excpetion to the rule for minimum chef version as I touched on in slack. If we're going Chef 15 then there's no reason to keep this cookbook around at all as the d and access resources are built in.

The only reason to update this is because it's used in the chef-client cookbook and will raise deprecation warnings until it's either removed from there or this PR gets merged and chef update the dependencies.

It'd probably be better to remove it but I know they won't want to break backwards compatibility as I imagine 99% of chef users are using chef-client in some capacity.

kitchen-porter commented 3 years ago

Released as: 7.0.0