sous-chefs / firewall

Development repository for the firewall cookbook
https://supermarket.chef.io/cookbooks/firewall
Apache License 2.0
99 stars 150 forks source link

Adding rule_enabled windows helper method #148

Closed jmccleery closed 8 years ago

jmccleery commented 8 years ago

Description

This allows a user to check if a firewall rule is enabled.

Issues Resolved

None

Check List

martinb3 commented 8 years ago

Hi there -- this is failing some specific rubocop rules, and it isn't actually being used anywhere. We have been very deliberate about not trying to parse the current state of the firewall, and instead rely on our own rules file that we build, when checking if things have changed and we need to re-run the rule file against the firewall. I'm not sure this kind of state-check method is something I want to include.

If you'd like to re-open as a passing PR, and want to further discuss the need for this method, I'd be more than glad to do so. I'm open to changes/improvements, but without a Windows-knowledgeable maintainer, I'm reticent to accept contributions like this. Thank you!