Adds ability to pass package options through to firewall package install

sous-chefs / firewall

Development repository for the firewall cookbook

https://supermarket.chef.io/cookbooks/firewall

Apache License 2.0

99 stars 150 forks source link

Adds ability to pass package options through to firewall package install #152

Closed zeddicus76 closed 8 years ago

zeddicus76 commented 8 years ago

Description

This change allows package_options to be passed through to the package install for firewall

Issues Resolved

Our environment requires package_options to avoid hanging during the install. This modification allowed that to happen.

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

martinb3 commented 8 years ago

Hi there -- would you mind adding the DCO to this commit?

zeddicus76 commented 8 years ago

I am waiting to find out from my company how I get the OK to add the DCO. It looks like I will be able to do it in the next week or so.

martinb3 commented 8 years ago

You can also add "Obvious fix." to the commit message to invoke the obvious fix clause, and skip the DCO. I think this commit would apply.

zeddicus76 commented 8 years ago

Anything else I need to do for the Obvious Fix sign off?

martinb3 commented 8 years ago

Hi there -- I cherry picked the two 'obvious fix' commits so I didn't have to merge this branch (it seems to have a lot of extra commits now via a merge commit). Have a look at master and be sure it looks good for your needs 👍

Thanks for the contribution!