[WIP] Make graphite great again

sous-chefs / graphite

Development repository for the graphite cookbook

https://supermarket.chef.io/cookbooks/graphite

Apache License 2.0

154 stars 210 forks source link

[WIP] Make graphite great again #296

Closed abilun closed 6 years ago

abilun commented 6 years ago

This PR does:

Fixes group and user ownership for python packages
Installs graphite packages the right way
Makes uwsgi recipe work
Django and Twisted packages are no longer pinned by default, it is assumed that proper versions will be installed as dependencies of carbon and graphite-web packages

abilun commented 6 years ago

@damacus, @tas50, please take a look at my changes

damacus commented 6 years ago

That looks good apart from cookstyle complaining.

If you've got chefdk run chef exec delivery local all and that'l run all the linting and unit tests

abilun commented 6 years ago

Also, why don't we move handling file resource from recipes to accumulator resource?

abilun commented 6 years ago

By the way, unit tests are entirely broken, since @tas50 rewrote some resources and I need help to cope with them.

tas50 commented 6 years ago

Merging as this is certainly an improvement over the current state. The specs are totally busted since I converted some of those old LWRPs to custom resources. Until we get solid support for testing resources in ChefSpec those should probably get deleted.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.