sous-chefs / graphite

Development repository for the graphite cookbook
https://supermarket.chef.io/cookbooks/graphite
Apache License 2.0
154 stars 210 forks source link

Add optional debug parameter for carbon_* services #304

Closed abilun closed 6 years ago

karcaw commented 6 years ago

This merge seems to fail with the following error:

           Error executing action `enable` on resource 'graphite_service[relay]'
           ================================================================================

           NoMethodError
           -------------
           undefined method `append' for []:Array

           Cookbook Trace:
           ---------------
           /tmp/kitchen/cache/cookbooks/graphite/resources/service.rb:42:in `manage_systemd_service'
           /tmp/kitchen/cache/cookbooks/graphite/resources/service.rb:23:in `block in class_from_file'

           Resource Declaration:
           ---------------------
           # In /tmp/kitchen/cache/cookbooks/<redacted>/recipes/graphite_frontend.rb

            34: graphite_service 'relay'
            35:

           Compiled Resource:
           ------------------
           # Declared in /tmp/kitchen/cache/cookbooks/<redacted>/recipes/graphite_frontend.rb:34:in `from_file'

           graphite_service("relay") do
             action [:enable]
             default_guard_interpreter :default
             declared_type :graphite_service
             cookbook_name "<redacted>"
             recipe_name "graphite_frontend"
           end

           System Info:
           ------------
           chef_version=13.8.5
           platform=centos
           platform_version=7.5.1804
           ruby=ruby 2.4.3p205 (2017-12-14 revision 61247) [x86_64-linux]
           program_name=chef-client worker: ppid=31364;start=17:49:23;
           executable=/opt/chef/bin/chef-client

i seems that a ruby Array does not have the .append in ruby version in chef 13, or even back to chef 12, which you still claim to support in the metadata.rb file.

If you like i could work up a PR to fix this properly.

abilun commented 6 years ago

@karcaw, https://github.com/sous-chefs/graphite/pull/305

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.