sous-chefs / graphite

Development repository for the graphite cookbook
https://supermarket.chef.io/cookbooks/graphite
Apache License 2.0
154 stars 210 forks source link

Typos in federated recipe #95

Closed rodriguezsergio closed 11 years ago

rodriguezsergio commented 11 years ago

Shouldn't this

graphite_results.each do |result|
        destinations << "#{result['fqdn']}:#{result['graphite']['carbon']['pickle_receiver_port']}:a"

read node['graphite']['carbon'] ?

https://github.com/hw-cookbooks/graphite/blob/master/recipes/federated.rb#L51

rodriguezsergio commented 11 years ago

Also, this node.default['graphite']['carbon']['relay']['relay_method'] = "consistent-hashing" should be default['graphite']['carbon']['relay']['method'] = "rules" # rules | consistent-hashing

https://github.com/hw-cookbooks/graphite/blob/master/recipes/federated.rb#L34 https://github.com/hw-cookbooks/graphite/blob/master/attributes/carbon_relay.rb#L12

and

node.default['graphite']['carbon']['relay']['udp_receiver_port'] = 2003 is a non-existent attribute (at least in the attributes folder). https://github.com/hw-cookbooks/graphite/blob/master/recipes/federated.rb#L32

which is unused in

https://github.com/hw-cookbooks/graphite/blob/master/templates/default/carbon.conf.erb. So either the relevant line needs to be added to the carbon.conf template or that line be removed from the federated recipe.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.