search

sous-chefs / haproxy

Development repository for the haproxy cookbook
https://supermarket.chef.io/cookbooks/haproxy
Apache License 2.0
158 stars 248 forks source link

Add `ssl_lib` and `ssl_inc` properties to `haproxy_install` #463

Closed derekgroh closed 3 years ago

derekgroh commented 3 years ago

Description

Add ssl_lib and ssl_inc properties to haproxy_install

Addresses missing commits in #454, supersedes #462

Issues Resolved

None

Contribution Check List

the-label-bot[bot] commented 3 years ago

Kind Prediction: test Confidence: 0.691

Provide the bot with feedback using a :thumbsup: or :thumbsdown:!

the-label-bot[bot] commented 3 years ago

Size Prediction: large Confidence: 0.999

This might take someone longer to review. Suggestion: Breaking it up into smaller pieces might be helpful.

Provide the bot with feedback using a :thumbsup: or :thumbsdown:!

derekgroh commented 3 years ago

Should additional platforms be covered in the CI?

source-lua was used as an example, but it seems the platform coverage is limited overall.

bmhughes commented 3 years ago

Should additional platforms be covered in the CI?

source-lua was used as an example, but it seems the platform coverage is limited overall.

Yes I was going to suggest that, run it on as many platforms as possible. Use the source suites as an example to follow unless there's an overly hard to work around issue with a platform, in which case just exclude the problem platform(s).

derekgroh commented 3 years ago

Feel like I'm going in circles trying to get an OS exclude for fedora-latest. Anyone know how best to do so?

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-excluding-configurations-from-a-matrix Seems to document the format as strings in brackets without quotes, but the checks failed to either value.

bmhughes commented 3 years ago

Feel like I'm going in circles trying to get an OS exclude for fedora-latest. Anyone know how best to do so?

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-excluding-configurations-from-a-matrix Seems to document the format as strings in brackets without quotes, but the checks failed to either value.

Looks correct to me and the latest action runs has excluded as configured? Unless I'm missing something?

derekgroh commented 3 years ago

Guess GitHub Actions was broken at the time, kept getting failures. Guess the question is which format is best?

Assume ffb1e74 would be best

kitchen-porter commented 3 years ago

Released as: 12.1.0