Switch from Berksfile to Policyfile

sous-chefs / haproxy

Development repository for the haproxy cookbook

https://supermarket.chef.io/cookbooks/haproxy

Apache License 2.0

158 stars 250 forks source link

Switch from Berksfile to Policyfile #465

Closed damacus closed 1 year ago

damacus commented 3 years ago

Description

Add a stub recipe because Policyfile blows up without it
Add the Policyfile with the named_run_list from the Habitat coobkook (thanks @sam1el)
Fix the spec_helper to use Policyfile

Issues Resolved

Berkshelf doesn't currently support Ruby 3.0's splat, Policyfile does so we're going to switch.

Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

bmhughes commented 3 years ago

I echo my comments from slack, I just don't see the benefit this gives 🤷‍♂️ (sous wise anyway) but I'm pretty neutral feeling about it in general so I'm happy to go with the majority.

I'd switch the named run list out for something like below though to keep it all in block scope, not to have to worry about "." and ".." and it's more idiomatic ruby imo.

Dir.each_child('./test/cookbooks/test/recipes') { |test| named_run_list test.to_sym, "test:#{test}" }

bmhughes commented 3 years ago

Ah I just seen that we're hitting a bug, so now it has a benefit ignore that part of ^, but I'm still not loving it.