search

sous-chefs / haproxy

Development repository for the haproxy cookbook
https://supermarket.chef.io/cookbooks/haproxy
Apache License 2.0
158 stars 250 forks source link

Adding Prom Exporter compile flag #466

Closed Wicaeed closed 3 years ago

Wicaeed commented 3 years ago

Description

HAProxy 2.4 adds a Makefile argument to enable the HAProxy built-in Prometheus exporter. Previously this was a multi-step process. Only works in HAProxy versions 2.4+

Issues Resolved

None

Check List

damacus commented 3 years ago

Nice! Thanks for the PR. I think we can actually replace the 1.8 test suite with 2.4 now that 1.8 has gone EOL and 2.4 is LTS

damacus commented 3 years ago

Rerunning the jobs now that the new workstation release is out. There have been some funky Gem issues this month!

ramereth commented 3 years ago

Rerunning the jobs now that the new workstation release is out. There have been some funky Gem issues this month!

We're still waiting on a new release to address the current segfault issues we're seeing.

Wicaeed commented 3 years ago

Ah OK, so the CI failures aren't necessarily anything to do with my changes, but the CI platform itself?

ramereth commented 3 years ago

@Wicaeed yes. We'll rerun this once it's fixed upstream (which should hopefully be soon:tm:)

gganley commented 3 years ago

@ramereth Hello! Has that segfault issue been fixed in upstream? If not do you happen to have a link to where I can track the progress on that issue specifically so this PR can be unblocked?

bmhughes commented 3 years ago

@ramereth Hello! Has that segfault issue been fixed in upstream? If not do you happen to have a link to where I can track the progress on that issue specifically so this PR can be unblocked?

@gganley This is fixed now so couple of small changes needed and we can get this merged and released.

kitchen-porter commented 3 years ago

Released as: 12.2.0