sous-chefs / homebrew

Development repository for the homebrew cookbook
https://supermarket.chef.io/cookbooks/homebrew
Apache License 2.0
151 stars 136 forks source link

Add temporary sudoers entry to fix homebrew installation #173

Closed williamtheaker closed 1 year ago

williamtheaker commented 1 year ago

Description

The README says "[t]his cookbook installs Homebrew," which isn't exactly true since installing Homebrew requires elevated permissions. This PR adds a sudo resource to add a temporary entry to sudoers.d with an allowlist of each binary called by the installation script's execute_sudo function. NONINTERACTIVE is set as an environment variable to toggle non-interactive installation (added in https://github.com/Homebrew/install/pull/614).

Issues Resolved

List any existing issues this PR resolves

Check List

damacus commented 1 year ago

I thought I had fixed this, but obviously not well enough.

Rspec is looking for a full path of /usr/local/bin/brew and we're using a different one. We really actually don't care about the path. Care to take on fixing that annoying bug at the same time please?

williamtheaker commented 1 year ago

Care to take on fixing that annoying bug at the same time please?

done

kitchen-porter commented 1 year ago

Released as: 5.4.0