search

sous-chefs / homebrew

Development repository for the homebrew cookbook
https://supermarket.chef.io/cookbooks/homebrew
Apache License 2.0
152 stars 136 forks source link

Massage Chef12HomebrewUser.find_homebrew_uid into username #72

Closed kbruner closed 9 years ago

kbruner commented 9 years ago

Fixes https://github.com/opscode-cookbooks/homebrew/issues/71

chef-supermarket commented 9 years ago

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

kbruner commented 9 years ago

Trying to get an issue with my supermarket account fixed, but in the meantime, I think this qualifies under The Obvious Fix Rule

kbruner commented 9 years ago

CLA signed!

trinitronx commented 9 years ago

Tested out this pull request on OS X Yosemite (10.10.3) and can confirm it fixes #71. Tested with Chef version 12.3.0

chilicheech commented 9 years ago

Folks, when can we get this merged and released? This cookbook in non-functional on chef 12.3.0 without this fix.

hiremaga commented 9 years ago

Big +1. Is there anything we might do to help get this merged? On Thu, Jun 18, 2015 at 9:49 AM Thiago Oliveira notifications@github.com wrote:

Folks, when can we get this merged and released? This cookbook in non-functional on chef 12.3.0 without this fix.

— Reply to this email directly or view it on GitHub https://github.com/opscode-cookbooks/homebrew/pull/72#issuecomment-113216268 .

jtimberman commented 9 years ago

Does it continue to work on versions > 12.0.0 < 12.3.0? Does it work on Chef 11?

hiremaga commented 9 years ago

IIRC the conditional on homebrew_mixin.rb:31 flows to line 39 on Chef 12.0.3 (and Chef 11). I believe this is why we've been able to workaround this issue by downgrading and locking to either Chef 12.0.3 or Chef 11.

treyhyde commented 9 years ago

this patch put us back in business, thanks