search

sous-chefs / homebrew

Development repository for the homebrew cookbook
https://supermarket.chef.io/cookbooks/homebrew
Apache License 2.0
152 stars 136 forks source link

Update install_formulas.rb #98

Closed alex-slynko closed 8 years ago

alex-slynko commented 8 years ago

Allow to pass custom options to brew packages. I.e. brew install vim --with-lua

chef-supermarket commented 8 years ago

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

tas50 commented 8 years ago

There's a rubocop failure showing up in travis for this. Can you fix the trailing whitespace.

chef-supermarket commented 8 years ago

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

alex-slynko commented 8 years ago

@tas50 I fixed the rubocop issue. Added documentation.

Additionally I changed options to be a string, like it is now in Chef resource

alex-slynko commented 8 years ago

@tas50 Could you please check this again?

tas50 commented 8 years ago

Thanks @alex-slynko