sous-chefs / java

Development repository for the java cookbook

https://supermarket.chef.io/cookbooks/java

Apache License 2.0

386 stars 636 forks source link

Update default download URL and checksum for oracle jdk 8 x86_64 #518

Closed y-batsianouski closed 5 years ago

y-batsianouski commented 5 years ago

Description

Update oracle jdk 8 x86_64 url and checksum

Issues Resolved

517

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

JohnRoesler commented 5 years ago

@y-batsianouski could you add a change log entry?

JohnRoesler commented 5 years ago

Also, wondering if we should go ahead and update all the URLs as the current version of 8 and likely others is out of date in the cookbook.

y-batsianouski commented 5 years ago

@JohnRoesler Should I bump version of the cookbook? up to 3.1.3? Otherwise I don't know where exactly to add entry in CHANGELOG :slightly_smiling_face:

Also I can update URLs for other java versions today later, np. I did not do it because I haven't a time when I prepared PR. But I think I will be usefull for others.

JohnRoesler commented 5 years ago

@y-batsianouski usually there is an unreleased section at the top, like https://github.com/sous-chefs/haproxy/blob/master/CHANGELOG.md

damacus commented 5 years ago

Hey @y-batsianouski are you still interested in getting this merged at all? We would love this contribution! 👍

majormoses commented 5 years ago

Since I had to rebase the branch anyways I added a changelog entry for you

y-batsianouski commented 5 years ago

Hello @majormoses ! Sorry for the late reply and thank you to release that changes!

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.