Fix for issue 538 to paramaterize file_cache_path references

teknomar7 commented 5 years ago

Description

This change creates a node attribute default['java']['download_path'] which defaults to Chef::Config[:file_cache_path]. All references to Chef::Config[:file_cache_path] have been replaced by node['java']['download_path'] which allows wrappers to set the value of the download and extract path of the tarball to a location other than Chef::Config[:file_cache_path]. These references were not replaced in spec files.

Issues Resolved

This is a resolution to issue 538. The path to download and extract the tarball was hardcoded to Chef::Config[:file_cache_path] which caused failures at my organization due to a 500 mb partition sizing for /var/chef across the organization.

Check List

Note: All tests did not pass on the master branch prior to modifying the code, so similar tests failed when running the same tests after code modifications.

[ ?] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ x] New functionality includes testing.
[ x] New functionality has been documented in the README if applicable

kitchen-porter commented 5 years ago

	1 Warning
:warning:	This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

teknomar7 commented 5 years ago

Lint test fails due to "accept license" prompt for chef exec that times out.

JohnRoesler commented 5 years ago

@teknomar7 I've opened PRs to resolve this https://github.com/sous-chefs/java/pull/555 & https://github.com/sous-chefs/terraform-github-org/pull/180

teknomar7 commented 5 years ago

@JohnRoesler Will I need to do anything else to retrigger the lint test (or anything further in general)? I'm a little new to this whole process.

Thanks!

JohnRoesler commented 5 years ago

Once those PRs get merged - this PR will ask us to merge those change in and that should do it 👍

teknomar7 commented 5 years ago

Is there any target date for when this might be included in a release to the master branch? Just want to keep my org apprised since I wrote a temporary work around in lieu of using this cookbook.

JohnRoesler commented 5 years ago

@majormoses fancy doing a release for 4.2 once this gets updated and merged?

majormoses commented 5 years ago

released: https://supermarket.chef.io/cookbooks/java/versions/4.2.0

sous-chefs / java