New resource AdoptOpenJDK

sous-chefs / java

Development repository for the java cookbook

https://supermarket.chef.io/cookbooks/java

Apache License 2.0

386 stars 637 forks source link

New resource AdoptOpenJDK #589

Closed damacus closed 4 years ago

damacus commented 4 years ago

Description

Add new resource adopt_openjdk

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

github-actions[bot] commented 4 years ago

	1 Warning
:warning:	This is a big Pull Request.

Generated by :no_entry_sign: Danger

xorima commented 4 years ago

can you stick debian-10 in the github actions for this cookbook please?

damacus commented 4 years ago

I can add Debian-10 in another PR. This one is already too big

damacus commented 4 years ago

One known issue with doing things the way I have, is if you override the URL, then you need to include the same path otherwise it won't guess the directory correctly e.g.

The current URL is similar to:

https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_x64_linux_hotspot_8u232b09.tar.gz

You need to throw the artefact in a folde with the same name jdk8u232-b09

damacus commented 4 years ago

I think this is ready to ship now 👍

All suites are passing for AdoptOpenJDK

damacus commented 4 years ago

I think this is ready to ship now 👍