Automated PR: Cookstyle Changes - Githubissues

sous-chefs / java

Development repository for the java cookbook

https://supermarket.chef.io/cookbooks/java

Apache License 2.0

386 stars 637 forks source link

Automated PR: Cookstyle Changes #606

Closed xorimabot closed 4 years ago

xorimabot commented 4 years ago

Hey! I ran Cookstyle 6.2.9 against this repo and here are the results. This repo was selected due to the topics of chef-cookbook

Changes

Issues found and resolved with resources/alternatives.rb

49:13 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal
62:13 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal
75:11 refactor: ChefCorrectness/ChefApplicationFatal - Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal

Issues found and resolved with resources/jce.rb

51:6 refactor: ChefStyle/UnnecessaryOSCheck - Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values.

kitchen-porter commented 4 years ago

	1 Warning
:warning:	This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger