search

sous-chefs / java

Development repository for the java cookbook
https://supermarket.chef.io/cookbooks/java
Apache License 2.0
386 stars 637 forks source link

Update InSpec tests to use inputs #657

Closed damacus closed 2 years ago

damacus commented 3 years ago

Attribute is now input

Signed-off-by: Dan Webb dan.webb@damacus.io

damacus commented 3 years ago

Looks like Corretto is broken again(?)

ramereth commented 3 years ago

Looks like Corretto is broken again(?)

Yup looks like we set the versions in the helper library. I wonder if we can pull the version from the http header using ruby libraries.

FWIW if you use curl you can see it:

curl -v https://corretto.aws/downloads/latest/amazon-corretto-8-x64-linux-jdk.tar.gz
< Location: /downloads/resources/8.302.08.1/amazon-corretto-8.302.08.1-linux-x64.tar.gz

We should be able to strip out the version number easily I think.

@jakauppila any thoughts?

jakauppila commented 3 years ago

Looks like Corretto is broken again(?)

Yup looks like we set the versions in the helper library. I wonder if we can pull the version from the http header using ruby libraries.

FWIW if you use curl you can see it:

curl -v https://corretto.aws/downloads/latest/amazon-corretto-8-x64-linux-jdk.tar.gz
< Location: /downloads/resources/8.302.08.1/amazon-corretto-8.302.08.1-linux-x64.tar.gz

We should be able to strip out the version number easily I think.

@jakauppila any thoughts?

I’ll take a look tomorrow to see what we’re doing internally; we’re not relying on these endpoints, but have similar logic to the endpoints we host ourselves.

ramereth commented 2 years ago

This was fixed in #659