sous-chefs / jenkins

Development repository for the jenkins cookbook

https://supermarket.chef.io/cookbooks/jenkins

Apache License 2.0

424 stars 635 forks source link

Fix #670: Support old slave_jar_resource function still in use in windows slave… #671

Closed timor-raiman closed 6 years ago

timor-raiman commented 6 years ago

… provider

Description

Fix #670: Support old slave_jar_resource function still in use in windows slave

Issues Resolved

670

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

skylerto commented 6 years ago

@timor-raiman can you fix the CI issues and push back up?

libraries/slave_windows.rb:104:5: C: Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
        return @slave_jar_resource if @slave_jar_resource
    ^^^^
libraries/slave.rb:154:60: C: Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
      new_resource.labels |= current_resource.labels.select{ |i| i[/^prsrv_/] }

skylerto commented 6 years ago

@tas50 any chance this could be merged in with the CI fixes?

tas50 commented 6 years ago

This will need to be DCO signed off before we can merge it.

tas50 commented 6 years ago

Closing in favor of #672