Fix plugin version parsing

arothian commented 6 years ago

Description

Several Jenkins plugins use versioning schemes that do not match with standard gem versioning. In these cases, version strings will actually parse (thus the rescue is not called) if they would be considered a "prerelease" gem.

For example, Gem::Version.new('4.5.3-2.0') becomes 4.5.3.pre.2.0. This causes Jenkins plugins that match this type of error to always install the latest version, as this substitution results in a noop. See included test case for an example that currently fails against master.

This change throws out any parsed Gem::Version instances that would be considered a "prerelease" and uses string based version matching.

Issues Resolved

GH-676

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

tas50 commented 6 years ago

Thanks for the fix

Dispader commented 6 years ago

I wonder if this fix also addresses Issue #534 . I'll give it a test when a version of the cookbook drops with this commit.

sous-chefs / jenkins