Closed josh-barker closed 6 years ago
This is a WIP. Need Travis to run tests.
Hey @tas50
This PR is almost finished; I just need to
Can you review before I do the final cleanup, or did you want me to delete all the ServerSpec files first?
I'm not fussed either way, but it could be easier to compare the ServerSpec tests vs the InSpec tests file to file, rather than git diff
, as there's going to be a lots of files deleted.
For example, comparing test/integration/jenkins_job_*/*
with test/integration/jenkins_smoke/controls/jenkins_job.rb
This is massive and seems all legit. Thank you so much for taking the time to put it all together. Nothing stands out to me so feel free to keep on the good work and I can merge this whenever you want. I added you as a collaborator on the cookbook since at this point you know ore about the setup of things than I do.
No worries. :) I'll keep cleaning it up & will let you know when its ready
@josh-barker any reason not to merge what you have here and then do any further cleanup in another PR. It would be great to get this on master.
Hey @tas50, sounds good. Let's get this into master. :-)
Description
This is to increase the test coverage for the cookbook.
Issues Resolved
30
seconds in kitchen file (https://github.com/chef-cookbooks/jenkins/pull/692/commits/1f3f817ec17f869a717f3cc0ada88f7d4e6a97bf)delete
action on jnlp slave (https://github.com/chef-cookbooks/jenkins/pull/692/commits/a00572c305c985578bfbe07875e0dd055cbc9400)ServerSpec
resources toInSpec
resourcesServerSpec
tests toInSpec
testsTo Do:
Check List