search

sous-chefs / jenkins

Development repository for the jenkins cookbook
https://supermarket.chef.io/cookbooks/jenkins
Apache License 2.0
424 stars 635 forks source link

vestigial addons still showing in config? #697

Closed bby-bishopclark closed 4 years ago

bby-bishopclark commented 6 years ago

Cookbook version

6.2.0

Chef-client version

13.2.20

Platform Details

RHEL7.5/Centos

Scenario:

Following #199 , using groovy to set in the XML config for a plugin, I notice that removing the plugin (deleting hpi and dir and restarting service) still leave the configuration in the server.xml file -- of course, because removing the blob doesn't actually remove anything else as it's a bad un/install method!

But that's the best route I have so far, so critique that on the way through if you can.

Steps to Reproduce:

Expected Result:

Removal of a plugin should not provide misleading config options behind. We can fix this, but only if we skip the anti-pattern (third-party configurator tools with no sense of installation state) mentioned as a solution in #199 , or if there's another configurator block to facilitate an uninstall (when chef can know what was installed, compare it with that's installed now to determine what config to remove, and then line-hack the config.xml to remove the config and then adjust it further around other plugins that may need new defaults when....

... or just write the XML file via template and also get idempotence and checksums as a bonus.

Actual Result:

github-actions[bot] commented 4 years ago

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

github-actions[bot] commented 4 years ago

Closing due to inactivity. If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.