Add extra variables as attributes

sous-chefs / jenkins

Development repository for the jenkins cookbook

https://supermarket.chef.io/cookbooks/jenkins

Apache License 2.0

424 stars 635 forks source link

Add extra variables as attributes #700

Closed rnt closed 4 years ago

rnt commented 6 years ago

Description

This PR allow to users to set extra environment variables to init scripts. For example, setting configuration-as-code plugin I need to set CASC_JENKINS_CONFIG variable on sysconfig file (RHEL/CentOS using package).

Issues Resolved

None.

acrewdson commented 5 years ago

I recently ran into this same situation with respect to JCasC (as mentioned above by @rnt). I imagine this will become a more frequent problem for people as JCasC is more widely adopted: initial provisioning of Jenkins with this cookbook, then further configuration with JCasC. The changes in this PR will be important to have.

acrewdson commented 5 years ago

Just expressing support again for merging this PR, it'd be a huge help. /cc @tas50

Thanks!

acrewdson commented 5 years ago

Checking again on whether this might be merge-able. Let me know if there's anything I can do to help make that happen. Thank you!

tas50 commented 4 years ago

Thanks @rnt