jenkins-cli uses -auth instead of --username, --password

itmustbejj commented 5 years ago

Signed-off-by: Jakob Pfeiffer pgp-jkp@pfeiffer.ws

Description

[Describe what this change achieves]

Issues Resolved

[List any existing issues this PR resolves]

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

acrewdson commented 5 years ago

Hi folks,

First, thanks for this cookbook. It's hugely appreciated.

Just adding my two cents to say: getting this PR merged and released would be a great help to people using certain Jenkins auth schemes. Right now, stuff is broken for us.

/cc @tas50

tas50 commented 5 years ago

Thanks @itmustbejj

stevenbaker commented 5 years ago

Just adding my two cents to say: getting this PR merged and released would be a great help to people using certain Jenkins auth schemes. Right now, stuff is broken for us.

+1 to @acrewdson's idea of cutting a new release of this cookbook soon with this change in it, mostly because of the remoting CLI being fully removed in 2.165 a few days ago.

Because of that, this PR becomes more urgent. A lot of devs out there might be in the same boat as us - taking another look at how this cookbook is authenticating with Jenkins to do its thing because the old way is gone.

A fresh version of this cookbook that includes this change would allow the cookbook to properly mirror the latest jenkins-cli commandline parameters - and that would be fantastic. 🎉

sous-chefs / jenkins