update plugin resource to simply work

[Stromweld]

update plugin resource to work with newer versions of Jenkins which f…ixes dependencies and removes need for additional plugin method

Signed-off-by: Corey Hemminger hemminger@hotmail.com

Description

Makes plugin lwrp useful. For latest version of plugins it'll install plugin and all dependencies via the jenkings-cli.jar install-plugin command. Newer versions of Jenkins this works great. Removes the need to brute force dependency install that would loop through all dependencies and dependencies of dependencies even if they have repeating depencies and differing versions of dependencies.

When specifying a source or specific version dependencies are not resolved and specific plugin is installed similar to old functionality based on url or file source on node.

Check List

• [ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
• [x] New functionality includes testing.
• [x] New functionality has been documented in the README if applicable
• [x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

[Stromweld]

This should fix issues #694 #653 #534 #631 #503 #494

[tas50]

@josh-barker thoughts on this change since you did all the last work here?

[Stromweld]

@josh-barker when you have some time could you look at these failing tests? Run log looks like they worked. The apache-httpcomponents plugin one I'm not sure why it didn't install the specific version, even though the plugins specifying version or source installed correct version.

[josh-barker]

Hi @stromweld, are you sure the correct version of apache-httpcomponents is being installed?

I spun it up and it had a newer version, not the version specified.

[Stromweld]

that was the result I got too, but if you look at the other tests that are specifying version or url and those specific versions are getting installed correctly and passing their tests. Not sure why only this one doesn't.

[Stromweld]

@josh-barker I merged in your branch #708 thanks for the fix

[Stromweld]

@tas50 this should be ready for final review.

[tas50]

Just a few minor things and this is ready to go out.

[Stromweld]

thanks for the merge