Adding cli user and password options

sous-chefs / jenkins

Development repository for the jenkins cookbook

https://supermarket.chef.io/cookbooks/jenkins

Apache License 2.0

424 stars 635 forks source link

Adding cli user and password options #717

Closed ddegoede closed 3 years ago

ddegoede commented 5 years ago

Description

This adds a specified user to use for basic authentication for the jenkins-cli using a username and password, where the password is a token

Signed-off-by: Daan de Goede ddegoede@schubergphilis.com

Issues Resolved

This partially fixes #599, is enables http protocol if a username and password is given.

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

xorima commented 3 years ago

Hey @ddegoede

Can you add a changelog entry for me so we can look to get this shipped?

Thanks!

ddegoede commented 3 years ago

Hi @Xorima will do so tomorrow. Thanks for checking this PR.

ddegoede commented 3 years ago

Hi @Xorima, I added/amended the changelog, hope you do not mind me taking credit for the groovy indentation fix, merged earlier. Also rebased and fixed the spec test.

kitchen-porter commented 3 years ago

Released as: 8.1.0

ddegoede commented 3 years ago

@Xorima that was quick 👍 I was just reading this page about the cli and authentication, and saw that it is actually the apitoken and not a password, shall I create a next MR to reflect this? And also add the option to use file based authentication for the -auth option?

xorima commented 3 years ago

@Xorima that was quick 👍 I was just reading this page about the cli and authentication, and saw that it is actually the apitoken and not a password, shall I create a next MR to reflect this? And also add the option to use file based authentication for the -auth option?

Yes please, I'm not a Jenkins expert by any means btw, I just merge stuff (releases are automated here)

Would you be willing to help maintain this cookbook as it sounds like you have a lot more knowledge than I do on Jenkins?

nuclearsandwich commented 3 years ago

Would you be willing to help maintain this cookbook as it sounds like you have a lot more knowledge than I do on Jenkins?

I'm happy to help review changes as well. Open Robotics is using this jenkins cookbook for several different large Jenkins instances and while our job configurations are all done outside of chef cutting away at the manual steps in bootstrapping and updating our global Jenkins configuration is a situation we're actively trying to improve.

xorima commented 3 years ago

For anyone willing to help maintain drop by #sous-chefs on chef community slack and we can walk you through the process of joining the org :)