search

sous-chefs / keepalived

Development repository for the keepalived cookbook
https://supermarket.chef.io/cookbooks/keepalived
Apache License 2.0
34 stars 80 forks source link

notify_master is duplicated on keepalived_vrrp_instance resources #151

Open john-scalingo opened 7 months ago

john-scalingo commented 7 months ago

:ghost: Brief Description

On vrrp_instances the notify_master script is duplicated.

:pancakes: Cookbook version

On versions after v4.0.0

Steps To Reproduce

Create an instance:

keepalived_vrrp_instance 'inside_network' do
  master true
  interface node['network']['default_interface']
  virtual_router_id 51
  priority 101
  authentication auth_type: 'PASS', auth_pass: 'secret1'
  virtual_ipaddress %w( 192.168.1.1 )
  notify_master "/tmp/test.sh"
  smtp_alert true
end

And run the cookbook. The file will contain the notify_master "/tmp/test.sh" line twice.

:police_car: Expected behavior

The generated file should contain the following line: notify_master "/tmp/test.sh" only once.

xorima commented 7 months ago

Can you raise a pr to fix this?

john-scalingo commented 7 months ago

I would love to. I have the PR ready but i need the approbation of my company for the Developer Certification of Origin. As soon as I have the go from my company I'll open the PR.