sous-chefs / logrotate

Development repository for the logrotate cookbook
https://supermarket.chef.io/cookbooks/logrotate
Apache License 2.0
122 stars 151 forks source link

Don't default frequency to weekly #136

Closed evandam closed 3 years ago

evandam commented 4 years ago

It should be possible to exclude frequency and let the value set in logrotate.conf apply, rather than always defaulting it to weekly.

For example, I have a separate cron job and config file for hourly logrotate:

# cat /etc/logrotate.hourly.conf
hourly
include /etc/logrotate.hourly.d

However, creating a logrotate config still defaults it to weekly:

# cat /etc/logrotate.hourly.d/app
# This file was generated by Chef.
# Do not modify this file by hand!

"/var/log/app.log" {
  weekly
  create 644 syslog adm
  rotate 24
  su root syslog
  missingok
  copytruncate
  notifempty
  dateext dateformat .%Y-%m-%d-%s
  compress
  sharedscripts
  postrotate
    invoke-rc.d rsyslog rotate >/dev/null 2>&1 || true
  endscript
}
welcomebot commented 4 years ago

Hey There It looks like this is the first issue you've filed against the chef-cookbooks project. I'm here to offer you a bit of extra help to make sure we can quickly get back to you. Make sure you've filled out all the fields in our issue template. Make sure you've provided us with the version of chef-client you're running, your operating system and the version of the cookbook. If you're not using the most up to date version of the cookbook then please make sure to update first. Lots of things change between versions even if you're issue isn't listed in the changelog. Finally please give us a detailed description of the issue you're having. The more we know about what you're trying to do, what actually happens, and how you can reproduce the problem, the better.

If you're looking for more immediate troubleshooting help make sure to check out #general on the Chef Community Slack. There's plenty of folks there willing to lend a helping hand. Thanks for the first issue. We hope we can get back to you soon with a solution.

github-actions[bot] commented 3 years ago

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

github-actions[bot] commented 3 years ago

Closing due to inactivity. If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.