sous-chefs / lvm

Development repository for the lvm cookbook

https://supermarket.chef.io/cookbooks/lvm

Apache License 2.0

56 stars 122 forks source link

[#217] Fix `pvcreate` and `lvcreate` not to wait for interactive input #218

Closed hamarituc closed 2 years ago

hamarituc commented 2 years ago

Signed-off-by: Mario Haustein mario.haustein@hrz.tu-chemnitz.de

Description

pvcreate and lvcreate wait for interactive input when the wipe_signatures property is not set. This PR changes their behavior to bail out immediately with an error message.

Issues Resolved

Check List

[x] A summary of changes made is included in the CHANGELOG under ## Unreleased
[ ] ~~New functionality includes testing.~~ not applicable
[ ] ~~New functionality has been documented in the README if applicable.~~ not applicable

damacus commented 2 years ago

Requires #216 before we can merge this so testing is working again.

schrd commented 2 years ago

Hi, I'd like to ask what is needed to get this one merged. Whitout this patch pvcreate and lvcreate may wait forever with no sensible output indicating the reason and calling both commands with -qq seems to be a safe fix for this.

bmhughes commented 2 years ago

If we can get all the tests passing then it can be merged, that appears to be the only thing blocking it.

schrd commented 2 years ago

Hmm, centos 8 tests are failing because centos is rolling release and has an updated LVM package for which chef-ruby-lvm-attrib attributes are missing. Attributes are already committed in chef-ruby-lvm-attrib but no release has been tagged yet. Fedora tests are failing because kitchen VMs are not reachable via ssh.

None of these failures are related to this PR. Centos would also fail with the latest release of this cookbook.

hamarituc commented 2 years ago

Is there anything I can do to finish this PR? The test suite fails during setting up the test environment, but the errors are not related to the portions of code changed by this patch. This issue is nearly a half year old and I neither see any way to make progress by myself nor perceive any indication someone is working on fixing the test suite.

Please leave a hint if there is someone currently working on the test suite and I just need to wait a bit longer. Otherwise I would be glad about an advice how to get forward in this matter.

Kind regards

Stromweld commented 2 years ago

looks like all the errors are due to vagrant rate limiting github actions. @ramereth what happened to the boxes at https://ftp.osuosl.org/pub/sous-chefs/bento/?

ramereth commented 2 years ago

looks like all the errors are due to vagrant rate limiting github actions. @ramereth what happened to the boxes at https://ftp.osuosl.org/pub/sous-chefs/bento/?

Apologies for removing those as we needed to free up some space. We actually have a work around which requires an API key to be added. I'll try and get that fixed up here.

ramereth commented 2 years ago

223 should fix this in theory. Once that gets merged, you should rebase.

kitchen-porter commented 2 years ago

Released as: 6.1.0