search

sous-chefs / mariadb

Development repository for the mariadb cookbook
https://supermarket.chef.io/cookbooks/mariadb
Apache License 2.0
49 stars 123 forks source link

Node search in galera setup results in excessive log output #90

Closed explody closed 7 years ago

explody commented 9 years ago

In galera.rb, after the node search is done, this snippet outputs a log entry (line ~69)

    log 'Chef search results' do
      message "Searching for \"#{node['mariadb']['galera']['cluster_search_query']}\" \
        resulted in \"#{galera_cluster_nodes}\" ..."
    end

Which results in the array of galera_cluster_nodes being dumped into the log, including the full structure of node attributes - over 200K of text in our case.

It's possible that we could suppress this with log level tweaking but I'm not sure that 200K of unformatted ruby hash would ever be useful in a log file - plus it could lead to a sensitive data leak depending on what's in the node attributes.

shoekstra commented 7 years ago

This has been moved to the debug log, so you shouldn't see this anymore.

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.