search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

[COOK-3352] Moved full path of repository_root attribute into attribute definition #21

Closed jlandahl closed 11 years ago

jlandahl commented 11 years ago

http://tickets.opscode.com/browse/COOK-3352

This will allow for full customization, e.g. to allow the standard behavior of having the local repository in $HOME/.m2/repository.

dbachelder commented 11 years ago

+1 please merge

gildegoma commented 11 years ago

:+1: (cool to see that this fix has been recently reviewed by opscode team :)

gildegoma commented 11 years ago

One more word on this request:

I am not sure that /usr/local/m2/repository is a good repository_root default value for user-wide /etc/mavenrc. Unless the cookbook offers a way to extend/customize the write permissions on the repository root (non-root ownership, or chmod 2775 tricks like this one, for instance), I think it is not convenient to refer to a "read-only" repository (forcing 'root' or sudo to install more dependencies).

I therefore think that setting default['maven']['repository_root'] = $HOME/.m2/repository in attributes/default.rb would better suites the general maven usage (dev boxes, build boxes).

@jlandahl If, as I guess, you share this opinion, I would encourage you to try to pack this change in COOK-3352 request.

gildegoma commented 11 years ago

@jlandahl please have a look into #24, I think make things even more easier and flexible...

sethvargo commented 11 years ago

Merged in 6b7c593