search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

update maven 3 version to 3.1.1 #27

Closed arussel closed 9 years ago

arussel commented 11 years ago

the newest version is 3.1.1, 3.1.0 is not available at this url anymore: http://apache.mirrors.tds.net/maven/maven-3/

hayesmp commented 11 years ago

Is it possible to override this in the mean time?

arussel commented 11 years ago

I had to override 2 attribute: override['maven']['3']['version'] = '3.1.1' override['maven']['3']['url'] = "http://apache.mirrors.tds.net/maven/maven-3/#{node['maven']['3']['version']}/binaries/apache-maven-#{node['maven']['3']['version']}-bin.tar.gz"

for some reason, if I override only mave/3/version, which should work, I end up with this weird situation: ark("maven") do provider Chef::Provider::Ark action :install updated true updated_by_last_action true retries 0 retry_delay 2 cookbook_name "maven" recipe_name "default" url "http://apache.mirrors.tds.net/maven/maven-3/3.1.0/binaries/apache-maven-3.1.0-bin.tar.gz" checksum "59088c62c14b996d597bbd55e720866b0e13e36daed8a46a81c01058ee74bd54" home_dir "/usr/local/maven" version "3.1.1" append_env_path true extension "tar.gz" prefix_bin "/usr/local/bin" path "/usr/local/maven-3.1.1" release_file "/srv/chef/file_store/maven.tar.gz" strip_leading_dir true owner "root" group 0 end

where maven/3/version is set properly, but maven/3/url is not using it

hayesmp commented 11 years ago

Yeah. I ended up setting the url without that fill-ins, but then I needed an older version anyway for usergrid-stack:

node.override['maven']['3']['version'] = '3.0.5'
node.override['maven']['3']['url'] = 'http://apache.mirrors.tds.net/maven/maven-3/3.0.5/binaries/apache-maven-3.0.5-bin.tar.gz'

For before I changed to ver 3.0.5, I did this and it worked (for 3.1.1):

node.override['maven']['3']['version'] = '3.1.1'
node.override['maven']['3']['url'] = 'http://apache.mirrors.tds.net/maven/maven-3/3.1.1/binaries/apache-maven-3.1.1-bin.tar.gz'
rhass commented 11 years ago

The patch needs to update the default SHA-256 checksum value as well. The new checksum value for Maven 3.1.1 is: 077ed466455991d5abb4748a1d022e2d2a54dc4d557c723ecbacdc857c61d51b

rhass commented 11 years ago

I have opened COOK-3849 for this issue.

https://tickets.opscode.com/browse/COOK-3849

arussel commented 11 years ago

you're right, it needs to be updated, but I'm seeing: 6342fdf6b0aabc1457c7f8cc218127ed at http://www.apache.org/dist/maven/maven-3/3.1.1/binaries/apache-maven-3.1.1-bin.tar.gz.md5 where did you get your checksum from ?

jtimberman commented 11 years ago

@arussel the checksum you posted looks like an md5. Chef uses SHA256 checksums for checking file content.

chef-supermarket commented 10 years ago

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

tas50 commented 9 years ago

Since the CLA hasn't been signed in over 6 month for this PR I'm going to close it out at this point. If the author would like to sign the CLA feel free to open up the PR again.