search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

support newer java cookbook versions #40

Closed andrewgoktepe closed 8 years ago

andrewgoktepe commented 10 years ago

The latest java cookbook is version 1.22.0 and does not satisfy the version constraint in the maven cookbook's metadata.rb. A 'berks install' fails when this combination of cookbooks is used.

Assuming the intent was only to prevent versions before 1.13, this change will support the latest version of the java cookbook.

I have tested and verified that this works with java cookbook 1.22.0

chef-supermarket commented 10 years ago

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

There are 1 commit author(s) whose commits are authored by a non GitHub-verified email address in this Pull Request. Chef will have to verify by hand that they have signed a Chef CLA.

Please sign the CLA here.

tas50 commented 8 years ago

Since the CLA hasn't been signed in over 6 month for this PR I'm going to close it out at this point. If the author would like to sign the CLA feel free to open up the PR again.

andrewgoktepe commented 8 years ago

I actually signed the ICLA back in July 2014 when the above chef-supermarket comment was posted. Is there something else I need to do to make it appear on this PR? I just logged into supermarket and it does show that I have already signed the ICLA and my github account is linked.