search

sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

check if M2_HOME or MAVEN_OPTS has already been set before setting. #45

Closed peterabbott closed 8 years ago

peterabbott commented 10 years ago

This will allow users/scripts to use a different version of Maven if required. The current setup will force you to the default installed version unless MAVEN_SKIP_RC is set. This seems a pain if all you want to do is override one or the other setting.

I don't have a DigitalOcean account but I provided my own test-kitchen file to test and verify with Docker

chef-supermarket commented 10 years ago

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

peterabbott commented 9 years ago

Unless I have missed something that is what this #45 is, no? I signed the CLA but nothing ever happened.

tas50 commented 8 years ago

Since the CLA hasn't been signed in over 6 month for this PR I'm going to close it out at this point. If the author would like to sign the CLA feel free to open up the PR again.

peterabbott commented 8 years ago

I definitely followed the process for signing the CLA when I submitted the PR, so not sure where the problem lies. I just went through and did it again so will see if it sticks this time.