Fix issue #46 - moved converge_by block inside get_maven_artifact

sous-chefs / maven

Development repository for the maven cookbook

https://supermarket.chef.io/cookbooks/maven

Apache License 2.0

36 stars 153 forks source link

Fix issue #46 - moved converge_by block inside get_maven_artifact #47

Closed moshezvi closed 9 years ago

moshezvi commented 10 years ago

This fix ensures that install only notifies when artifact has actually changed

chef-supermarket commented 10 years ago

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

There are 1 commit author(s) whose commits are authored by a non GitHub-verified email address in this Pull Request. Chef will have to verify by hand that they have signed a Chef CLA.

Please sign the CLA here.

tophercullen commented 9 years ago

This doesn't work for me as the new_resource.action is passed as an array, not a string, which doesn't have a capitalize method. The original implementation pass the action as a set string. I changed the function parameters to accept an action as string instead, and passed that with the get_mvn_artifact. Its not as clean, but it works now.

tas50 commented 9 years ago

Since the CLA hasn't been signed in over 6 month for this PR I'm going to close it out at this point. If the author would like to sign the CLA feel free to open up the PR again.