sous-chefs / maven

Development repository for the maven cookbook
https://supermarket.chef.io/cookbooks/maven
Apache License 2.0
36 stars 153 forks source link

Configurable timeout for maven resource #53

Closed maoo closed 8 years ago

maoo commented 9 years ago

When using maven LWRP for dowloading big artifacts, sometimes the operation takes more than 600 seconds and it fails for timeout; this Pull Request adds a timeout attribute in the maven resource that is passed to the shell_out command (thx @michaeldunstan for the suggestion)

Following https://github.com/maoo/maven/blob/master/TESTING.md, I've executed local runs with Kitchen, causing error by setting timeout=1; I've also tried to run rspec on the current Chef cookbook, but failed.

Also created an an account on https://tickets.opscode.com but not sure if I need to create a ticket there or not; please advise.

chef-supermarket commented 9 years ago

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

chef-supermarket commented 9 years ago

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

enzor commented 8 years ago

any update on this? :)